Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21491 )
Change subject: IMPALA-13143: Fix flaky test_catalogd_failover_with_sync_ddl ...................................................................... Patch Set 5: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/21491/4/tests/custom_cluster/test_catalogd_ha.py File tests/custom_cluster/test_catalogd_ha.py: http://gerrit.cloudera.org:8080/#/c/21491/4/tests/custom_cluster/test_catalogd_ha.py@486 PS4, Line 486: > changed to SYNC_DDL_DELAY_S * 2 + 10 Done http://gerrit.cloudera.org:8080/#/c/21491/5/tests/custom_cluster/test_catalogd_ha.py File tests/custom_cluster/test_catalogd_ha.py: http://gerrit.cloudera.org:8080/#/c/21491/5/tests/custom_cluster/test_catalogd_ha.py@487 PS5, Line 487: QueryState.EXCEPTION, SYNC_DDL_DELAY_S * 2 + 10 nit: Still not sure if query suppose to retry and talk with the newly active catalogd or not. If not, then SYNC_DDL_DELAY_S + 10 is probably OK. Anyway, waiting longer does no harm. -- To view, visit http://gerrit.cloudera.org:8080/21491 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15bb6aae23a2f544067f993533e322969372ebd5 Gerrit-Change-Number: 21491 Gerrit-PatchSet: 5 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 07 Jun 2024 18:32:27 +0000 Gerrit-HasComments: Yes
