Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/21482 )
Change subject: IMPALA-13137: Add additional client fetch metrics columns to the queries page ...................................................................... Patch Set 3: > Please add tests to tests/query_test/test_observability.py and/or > tests/webserver/test_web_pages.py. Also incldue example output in > the commit message as it's not clear what human readable means. Currently, there are not tests specifically written for the queries page table within tests. If required, I will post another patch for the tests. Including it in this patch may be ambiguous and might make it hard to find later. -- To view, visit http://gerrit.cloudera.org:8080/21482 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74a9393a7b38750de0c3f6230b6e5e048048c4b5 Gerrit-Change-Number: 21482 Gerrit-PatchSet: 3 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 12 Jun 2024 13:35:55 +0000 Gerrit-HasComments: No
