Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10345 )

Change subject: IMPALA-6645: Enable disk spill encryption by default
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/10345/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10345/3//COMMIT_MSG@7
PS3, Line 7: IMPALA-6635:
> IMPALA-6645
Done (this also addresses Kim's comment).


http://gerrit.cloudera.org:8080/#/c/10345/3//COMMIT_MSG@11
PS3, Line 11: PCLMULQDQ
> which CPUs introduced that?
Added to comment. Any server-class x86 processors < 5 years will have it.


http://gerrit.cloudera.org:8080/#/c/10345/3/tests/custom_cluster/test_disk_spill_configurations.py
File tests/custom_cluster/test_disk_spill_configurations.py:

http://gerrit.cloudera.org:8080/#/c/10345/3/tests/custom_cluster/test_disk_spill_configurations.py@33
PS3, Line 33: with a customer
> what does that mean?
I'm not sure what I meant.



--
To view, visit http://gerrit.cloudera.org:8080/10345
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee4be2a95d689f66c3663d99e4df0fb3968893a9
Gerrit-Change-Number: 10345
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Kim Jin Chul <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Wed, 09 May 2018 17:20:11 +0000
Gerrit-HasComments: Yes

Reply via email to