Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21482 )
Change subject: IMPALA-13137: Add additional client fetch metrics columns to the queries page ...................................................................... Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/21482/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21482/4//COMMIT_MSG@18 PS4, Line 18: fetch all rows > Done Done http://gerrit.cloudera.org:8080/#/c/21482/4//COMMIT_MSG@18 PS4, Line 18: fetch all rows > Done Done http://gerrit.cloudera.org:8080/#/c/21482/4/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/21482/4/be/src/service/impala-http-handler.cc@463 PS4, Line 463: " fetch all rows s > Done Done http://gerrit.cloudera.org:8080/#/c/21482/4/be/src/service/impala-http-handler.cc@548 PS4, Line 548: Coordinator::PROFIL > Done Done http://gerrit.cloudera.org:8080/#/c/21482/4/www/queries.tmpl File www/queries.tmpl: http://gerrit.cloudera.org:8080/#/c/21482/4/www/queries.tmpl@117 PS4, Line 117: <span title="{{tips_first_row_fetched}}">First row fetched</span> : <hr style="margin-top:0px;margin-bottom:0px;"/> : <span title="{{tips_client_fetch_wait_time}}">Client fetch wait time</span> > Yeah, I can agree with it. But, it may cause a misunderstanding, as the sam Different name between this table header and query profile is OK. I'd say go for it. You can clarify the association with query profile in the tooltip message. I think we should go with "First Fetch" and "Fetch Time". "Duration" is too long. http://gerrit.cloudera.org:8080/#/c/21482/5/www/queries.tmpl File www/queries.tmpl: http://gerrit.cloudera.org:8080/#/c/21482/5/www/queries.tmpl@54 PS5, Line 54: Queued Duration Please change this to "Queue Time" to save space. http://gerrit.cloudera.org:8080/#/c/21482/5/www/queries.tmpl@124 PS5, Line 124: Duration Please change this to "Queue Time" to save space. -- To view, visit http://gerrit.cloudera.org:8080/21482 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74a9393a7b38750de0c3f6230b6e5e048048c4b5 Gerrit-Change-Number: 21482 Gerrit-PatchSet: 5 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 14 Jun 2024 15:57:51 +0000 Gerrit-HasComments: Yes
