Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/21504 )
Change subject: IMPALA-13152: Avoid NaN, infinite, and negative ProcessingCost ...................................................................... Patch Set 3: Code-Review+1 (3 comments) General question, don't need to be addressed in this patch. Should we distinguish between missing cardinality information and 0 cardinality? 0 cardinality would mean no data to process while missing cardinality information means we don't have cardinality information likely due to missing stats and so we could probably use some default cardinality. http://gerrit.cloudera.org:8080/#/c/21504/3/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/21504/3/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@a2231 PS3, Line 2231: Why is this check no longer required? http://gerrit.cloudera.org:8080/#/c/21504/3/fe/src/main/java/org/apache/impala/planner/ScanNode.java File fe/src/main/java/org/apache/impala/planner/ScanNode.java: http://gerrit.cloudera.org:8080/#/c/21504/3/fe/src/main/java/org/apache/impala/planner/ScanNode.java@a399 PS3, Line 399: Why this check is no longer required? http://gerrit.cloudera.org:8080/#/c/21504/3/fe/src/main/java/org/apache/impala/planner/ScanNode.java@a420 PS3, Line 420: Same question. -- To view, visit http://gerrit.cloudera.org:8080/21504 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib49c7ae397dadcb2cb69fde1850d442d33cdf177 Gerrit-Change-Number: 21504 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 14 Jun 2024 22:38:53 +0000 Gerrit-HasComments: Yes
