Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21435 )
Change subject: IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder ...................................................................... Patch Set 5: (9 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/21435/3/be/src/exec/iceberg-delete-builder.h File be/src/exec/iceberg-delete-builder.h: http://gerrit.cloudera.org:8080/#/c/21435/3/be/src/exec/iceberg-delete-builder.h@70 PS3, Line 70: s > Nit: this should be "Processes". Done http://gerrit.cloudera.org:8080/#/c/21435/3/be/src/exec/iceberg-delete-builder.h@121 PS3, Line 121: ctor of vectors means we can just allocate another vector to hold : // subsequent eleme > Could you clarify this? Is it about 'intermediate_delete_rows_' in addition Rephrased a bit, I hope it's clearer now. http://gerrit.cloudera.org:8080/#/c/21435/3/be/src/exec/iceberg-delete-builder.h@149 PS3, Line 149: s > We usually take non-const (output) arguments by pointer. Done, also switched the parameters, as we prefer to have output parameters at the end. http://gerrit.cloudera.org:8080/#/c/21435/3/be/src/exec/iceberg-delete-builder.cc File be/src/exec/iceberg-delete-builder.cc: http://gerrit.cloudera.org:8080/#/c/21435/3/be/src/exec/iceberg-delete-builder.cc@184 PS3, Line 184: Inte > I think using the actual type (IntermediateDeleteRowVector&) is more readab Done http://gerrit.cloudera.org:8080/#/c/21435/3/be/src/exec/iceberg-delete-builder.cc@242 PS3, Line 242: auto > I think using the actual type (IntermediateDeleteRowVector&) is more readab The actual type is a pair<string, IntermediateDeleteRowVector>. I switched to structured binding as I think with proper variable names it is more readable. http://gerrit.cloudera.org:8080/#/c/21435/3/be/src/exec/iceberg-delete-builder.cc@250 PS3, Line 250: e_ve > I think using the actual type (vector<int64_t>) is more readable. Also L252 Done http://gerrit.cloudera.org:8080/#/c/21435/3/be/src/exec/iceberg-delete-builder.cc@296 PS3, Line 296: cons > I think using the actual type (vector<int64_t>) is more readable. Also L306 Done http://gerrit.cloudera.org:8080/#/c/21435/3/be/src/exec/iceberg-delete-builder.cc@319 PS3, Line 319: > Can we take it by const ref? Done http://gerrit.cloudera.org:8080/#/c/21435/3/be/src/exec/iceberg-delete-builder.cc@327 PS3, Line 327: > Can it happen that (*path) is not a key in 'intermediate_delete_rows_' but Done -- To view, visit http://gerrit.cloudera.org:8080/21435 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14541a064a522d4780fb5f02636736259e79b9cf Gerrit-Change-Number: 21435 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 17 Jun 2024 13:47:32 +0000 Gerrit-HasComments: Yes
