Wenzhe Zhou has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21539 )

Change subject: IMPALA-12754: [DOCS] External JDBC table support
......................................................................


Patch Set 1:

(14 comments)

http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml
File docs/topics/impala_jdbc_external_table.xml:

http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@22
PS1, Line 22: Support for Impala external JDBC data sources
Change title as "Using Impala to Query External JDBC Data Sources"


http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@40
PS1, Line 40: external table
external JDBC table


http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@41
PS1, Line 41: [EXTERNAL]
key word 'EXTERNAL' is mandatory for creating JDBC table, remove square brackets


http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@70
PS1, Line 70: port
change to default Postgres port: 5432


http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@93
PS1, Line 93: port
change to Impala default HS2 port: 21050


http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@98
PS1, Line 98:
add a line break


http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@107
PS1, Line 107: IMPALA
or IMPALA


http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@109
PS1, Line 109: hostname
hostname/IP address


http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@129
PS1, Line 129: Location
change to URI


http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@142
PS1, Line 142: an external
an Impala external


http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@154
PS1, Line 154: external
Impala external


http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@156
PS1, Line 156: Unsupported column data types include char, varchar, binary, 
complex
             :                     data types - struct, map, array, and nested 
type
Following column data types are not supported:
char, varchar, binary,
complex data types - struct, map, array, and nested type


http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@194
PS1, Line 194:
replace it with one space


http://gerrit.cloudera.org:8080/#/c/21539/1/docs/topics/impala_jdbc_external_table.xml@211
PS1, Line 211: JDBC external
external JDBC



--
To view, visit http://gerrit.cloudera.org:8080/21539
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5360389037ae9ee675ab406d87617d55d476bf8f
Gerrit-Change-Number: 21539
Gerrit-PatchSet: 1
Gerrit-Owner: Jankiram Balakrishnan <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: gaurav singh <[email protected]>
Gerrit-Comment-Date: Thu, 20 Jun 2024 00:42:59 +0000
Gerrit-HasComments: Yes

Reply via email to