Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21533 )
Change subject: IMPALA-13166: Optimize ExprSubstitutionMap allocation ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21533/1/fe/src/main/java/org/apache/impala/analysis/ExprSubstitutionMap.java File fe/src/main/java/org/apache/impala/analysis/ExprSubstitutionMap.java: http://gerrit.cloudera.org:8080/#/c/21533/1/fe/src/main/java/org/apache/impala/analysis/ExprSubstitutionMap.java@68 PS1, Line 68: Math.max(16, (lhs_.size() + 1) * 4 / 3) Please add a comment explaining this calculation. -- To view, visit http://gerrit.cloudera.org:8080/21533 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5e56401508f30e3066b1a3758d69d89a288adcd Gerrit-Change-Number: 21533 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 20 Jun 2024 16:35:38 +0000 Gerrit-HasComments: Yes
