Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/10100 )
Change subject: IMPALA-6923:Update scripts in benchmark folder to store workload and few minor updates ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/10100/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10100/8//COMMIT_MSG@7 PS8, Line 7: Update Please add a space in front of this. http://gerrit.cloudera.org:8080/#/c/10100/8/tests/benchmark/report_benchmark_results.py File tests/benchmark/report_benchmark_results.py: http://gerrit.cloudera.org:8080/#/c/10100/8/tests/benchmark/report_benchmark_results.py@141 PS8, Line 141: Dont I think either "Don't" or "Do not" is better than Dont. This is used for user's helper message. http://gerrit.cloudera.org:8080/#/c/10100/8/tests/benchmark/report_benchmark_results.py@1058 PS8, Line 1058: if exec_summaries[0] is None: : return "" I think this is a redundant special handling. I believe L1054-1055 can be merged into the L1058-1059 because there is no symbol dependent issue. e.g.) if options.hive_results or exec_summaries[0] is None: return "" -- To view, visit http://gerrit.cloudera.org:8080/10100 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ica7c00ad59963d466bae9e607a4692af0138962c Gerrit-Change-Number: 10100 Gerrit-PatchSet: 8 Gerrit-Owner: Nithya Janarthanan <njanartha...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Nithya Janarthanan <njanartha...@cloudera.com> Gerrit-Comment-Date: Thu, 10 May 2018 00:12:47 +0000 Gerrit-HasComments: Yes
