Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19827 )
Change subject: IMPALA-12093: impala-shell to preserve all cookies ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/19827/3/be/src/rpc/authentication-util.cc File be/src/rpc/authentication-util.cc: http://gerrit.cloudera.org:8080/#/c/19827/3/be/src/rpc/authentication-util.cc@40 PS3, Line 40: DEFINE_string_hidden(cookie_name, "impala.auth", This was the least invasive way I came up with to test wildcard cookie matching. Another option would be to make Impala return an additional Set-Cookie, then augment impala-shell to print what cookies it's preserving and verify that in the test. -- To view, visit http://gerrit.cloudera.org:8080/19827 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic81f790288460b086ab218e6701e8115a996dfa7 Gerrit-Change-Number: 19827 Gerrit-PatchSet: 3 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 20 Jun 2024 21:41:21 +0000 Gerrit-HasComments: Yes
