Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21478 )
Change subject: IMPALA-13120: Load failed table without need for manual invalidate ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/21478/4/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java File fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/21478/4/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java@332 PS4, Line 332: get( Should this be getOrDefault(tblName, null) to avoid unexpected null pointer exceptions? http://gerrit.cloudera.org:8080/#/c/21478/4/fe/src/main/java/org/apache/impala/analysis/StmtMetadataLoader.java@332 PS4, Line 332: tablesToLoad.get(tblName) == tbl Is there a scenario where tablesToLoad.get(tblName) != tbl && condition in L326-327? -- To view, visit http://gerrit.cloudera.org:8080/21478 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia882fdd865ef716351be7f1eaf203a9fb04c1c15 Gerrit-Change-Number: 21478 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 20 Jun 2024 22:40:56 +0000 Gerrit-HasComments: Yes
