Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21546 )
Change subject: IMPALA-9441,IMPALA-13170: Ops listing dbs/tables should handle db not exists ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21546/1/common/thrift/CatalogService.thrift File common/thrift/CatalogService.thrift: http://gerrit.cloudera.org:8080/#/c/21546/1/common/thrift/CatalogService.thrift@615 PS1, Line 615: VERSION_NOT_MATCH nit: maybe VERSION_MISMATCH would be better from a grammar perspective http://gerrit.cloudera.org:8080/#/c/21546/1/tests/authorization/test_authorization.py File tests/authorization/test_authorization.py: http://gerrit.cloudera.org:8080/#/c/21546/1/tests/authorization/test_authorization.py@265 PS1, Line 265: stop = True shouldn't be thread joined first? I assume that drop database could throw an exception if line below already cleaned the database up + I am not sure if doing the two in parallel is ok from the client side - the impyla client is not thread safe for example -- To view, visit http://gerrit.cloudera.org:8080/21546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2bd40d33859feca2bbd2e5f1158f3894a91c2929 Gerrit-Change-Number: 21546 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 26 Jun 2024 18:08:52 +0000 Gerrit-HasComments: Yes
