Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21114 )
Change subject: PROTOTYPE (IMPALA-9153): Incremental compilation for vendored cup-maven-plugin ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21114/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java File java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java: http://gerrit.cloudera.org:8080/#/c/21114/1/java/cup-maven-plugin/src/main/java/net/sourceforge/czt/cup/maven/CupGenerateMojo.java@437 PS1, Line 437: boolean generatedCodeOutOfDate = false; > Good point, that is something I'm missing. We want to look at any .dat file Would you like me to try and finish that? I've been recompiling Java a lot recently and this would be helpful. -- To view, visit http://gerrit.cloudera.org:8080/21114 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22c147f81ea8a5faf6c669e248489e5a9c2f5643 Gerrit-Change-Number: 21114 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 28 Jun 2024 19:43:26 +0000 Gerrit-HasComments: Yes
