Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21435 )
Change subject: IMPALA-13088: (part 1) Improve build batch processing of IcebergDeleteBuilder ...................................................................... Patch Set 9: (1 comment) > Patch Set 9: > > This is substantially rewritten with RoaringBitmaps. Do you plan to combine > them? I kept them separate because of the code review. But since now all reviewers are familiar with both patches I see no good reason to not squash them. http://gerrit.cloudera.org:8080/#/c/21435/9/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/21435/9/tests/query_test/test_scanners.py@528 PS9, Line 528: def test_iceberg_query_v2(self, vector): > I'm not sure I understand why this test change was needed but I most probab I think it was needed for the second part for some reason. I reverted it from the squashed patch for now. -- To view, visit http://gerrit.cloudera.org:8080/21435 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I14541a064a522d4780fb5f02636736259e79b9cf Gerrit-Change-Number: 21435 Gerrit-PatchSet: 9 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 01 Jul 2024 13:00:18 +0000 Gerrit-HasComments: Yes
