Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21239 )
Change subject: IMPALA-13043: Implement Join Capability to the Calcite Planner ...................................................................... Patch Set 11: (10 comments) http://gerrit.cloudera.org:8080/#/c/21239/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java: http://gerrit.cloudera.org:8080/#/c/21239/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java@223 PS11, Line 223: * generates a Left Outer Join and checks the nullability of the column being output from line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21239/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java@224 PS11, Line 224: * the right side of the LOJ. Since the literal TRUE is a non-null value coming into the join line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/21239/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java@225 PS11, Line 225: * but after the join becomes nullable, we add this function to ensure that happens. Without line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21239/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java@226 PS11, Line 226: * adding this function the direct translation would be 'TRUE IS NULL' which is incorrect. line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21239/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java@446 PS11, Line 446: // node. This is checked during the validatePlan(). In some cases, the check for small query line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/21239/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java@447 PS11, Line 447: // optimization (done at the end of the single node planning phase) will determine that the line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/21239/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java@448 PS11, Line 448: // cardinality of the query is lower than the exec_single_node_rows_threshold and will force line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/21239/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java@449 PS11, Line 449: // the num_nodes = 1. However, that check gets bypassed for some tests run through the test line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/21239/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaJoinRel.java@454 PS11, Line 454: (joinOp == JoinOperator.RIGHT_OUTER_JOIN || joinOp == JoinOperator.FULL_OUTER_JOIN) && line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21239/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/phys/ImpalaHashJoinNode.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/phys/ImpalaHashJoinNode.java: http://gerrit.cloudera.org:8080/#/c/21239/11/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/phys/ImpalaHashJoinNode.java@43 PS11, Line 43: super(leftInput, rightInput, isStraightJoin, distMode, joinOp, equiJoinConjuncts, nonEquijoinConjuncts); line too long (108 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21239 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5db097577907d79877f52feff2922000af074ecd Gerrit-Change-Number: 21239 Gerrit-PatchSet: 11 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 08 Jul 2024 23:12:00 +0000 Gerrit-HasComments: Yes
