Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21568 )
Change subject: IMPALA-13203: Rewrite 'id = 0 OR false' as expected ...................................................................... IMPALA-13203: Rewrite 'id = 0 OR false' as expected Currently, ExprRewriter cannot rewrite 'id = 0 OR false' to 'id = 0' as expected. More precisely, it fails to rewrite any cases where a boolean literal follows 'AND/OR' as expected. The issue is that the CompoundPredicate generated by NormalizeExprsRule is not analyzed, causing SimplifyConditionalsRule to skip the rewrite. This patch fixes the issue by adding analysis of the rewritten CompoundPredicate in NormalizeExprsRule. Testing: - Modified and passed FE test case ExprRewriteRulesTest#testCompoundPredicate - Modified and passed related test case Change-Id: I9d9fffdd1cc644cc2b48f08c2509f22a72362d22 Reviewed-on: http://gerrit.cloudera.org:8080/21568 Reviewed-by: Csaba Ringhofer <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/rewrite/NormalizeExprsRule.java M fe/src/test/java/org/apache/impala/analysis/ExprCardinalityTest.java M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java M testdata/workloads/functional-planner/queries/PlannerTest/constant-propagation.test M testdata/workloads/functional-planner/queries/PlannerTest/empty.test M testdata/workloads/functional-planner/queries/PlannerTest/hdfs.test 6 files changed, 23 insertions(+), 20 deletions(-) Approvals: Csaba Ringhofer: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/21568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9d9fffdd1cc644cc2b48f08c2509f22a72362d22 Gerrit-Change-Number: 21568 Gerrit-PatchSet: 5 Gerrit-Owner: Zihao Ye <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]>
