Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10365 )
Change subject: IMPALA-6035: Add query options to limit reserved threads ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10365/3/be/src/scheduling/query-schedule.h File be/src/scheduling/query-schedule.h: http://gerrit.cloudera.org:8080/#/c/10365/3/be/src/scheduling/query-schedule.h@61 PS3, Line 61: int64_t min_reservation_bytes = 0; This looked like a bug, because these were never explicitly initialised. Actually it isn't a bug because std::map guarantees primitives in values are zero-initialised if there isn't a default constructor: http://en.cppreference.com/w/cpp/container/map/operator_at -- To view, visit http://gerrit.cloudera.org:8080/10365 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b5bbbdad5cd6b24442eb6c99a4d38c2ad710007 Gerrit-Change-Number: 10365 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 10 May 2018 18:18:43 +0000 Gerrit-HasComments: Yes
