[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/20447 )
Change subject: [WIP] IMPALA-13039: AES Encryption/ Decryption Support in Impala ...................................................................... Patch Set 10: (1 comment) > Patch Set 10: > > (13 comments) http://gerrit.cloudera.org:8080/#/c/20447/10/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/20447/10/be/src/util/openssl-util.cc@287 PS10, Line 287: // supported, uncommenting it will result in an error. > I don't think we can accept this patch without handling errors here. To handle it properly, we'll need to add support for gcm_tag. It is scheduled in future steps, do you want me to add it in this patch itself? -- To view, visit http://gerrit.cloudera.org:8080/20447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3902f2b1d95da4d06995cbd687e79c48e16190c9 Gerrit-Change-Number: 20447 Gerrit-PatchSet: 10 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Comment-Date: Thu, 11 Jul 2024 13:03:45 +0000 Gerrit-HasComments: Yes
