Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21579 )
Change subject: POC: Add queuing to broadcast data sender ...................................................................... Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080/#/c/21579/1/be/src/runtime/krpc-data-stream-sender.h File be/src/runtime/krpc-data-stream-sender.h: http://gerrit.cloudera.org:8080/#/c/21579/1/be/src/runtime/krpc-data-stream-sender.h@170 PS1, Line 170: OutboundQueue(const std::vector<std::unique_ptr<Channel>>& channels, int queue_size, KrpcDataStreamSender* parent); line too long (119 > 90) http://gerrit.cloudera.org:8080/#/c/21579/1/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/21579/1/be/src/runtime/krpc-data-stream-sender.cc@192 PS1, Line 192: Status TransmitData(std::unique_ptr<OutboundRowBatch>* outbound_batch, bool swap_batch, bool* channel_closed=nullptr); line too long (120 > 90) http://gerrit.cloudera.org:8080/#/c/21579/1/be/src/runtime/krpc-data-stream-sender.cc@390 PS1, Line 390: RuntimeState* state, std::shared_ptr<CharMemTrackerAllocator> allocator, OutboundQueue* queue) { line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/21579/1/be/src/runtime/krpc-data-stream-sender.cc@883 PS1, Line 883: RETURN_IF_ERROR(channels_[i]->Init(state, char_mem_tracker_allocator_, broadcast_queue_.get())); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/21579/1/be/src/runtime/krpc-data-stream-sender.cc@1107 PS1, Line 1107: // TODO: update comment - TransmitData() will block if there are still in-flight rpcs (and those will line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/21579/1/be/src/runtime/krpc-data-stream-sender.cc@1329 PS1, Line 1329: while(queue_.size() == max_queue_size_ && !closed_ && !parent_->state_->is_cancelled()) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21579/1/be/src/runtime/krpc-data-stream-sender.cc@1359 PS1, Line 1359: //LOG(INFO) << "Add blocking free_batches_" << free_batches_.size() << " queue " << queue_.size(); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/21579/1/be/src/runtime/krpc-data-stream-sender.cc@1380 PS1, Line 1380: OutboundRowBatch* KrpcDataStreamSender::OutboundQueue::RpcFinished(OutboundRowBatch* batch, Channel* channel) { line too long (112 > 90) http://gerrit.cloudera.org:8080/#/c/21579/1/be/src/runtime/krpc-data-stream-sender.cc@1406 PS1, Line 1406: //LOG(INFO) << "RpcFinished, found in queue free batches:" << free_batches_.size() << " queue " << queue_.size(); line too long (122 > 90) http://gerrit.cloudera.org:8080/#/c/21579/1/be/src/runtime/krpc-data-stream-sender.cc@1414 PS1, Line 1414: //LOG(INFO) << "RpcFinished,. wait for addblocked free batches:" << free_batches_.size() << " queue " << queue_.size(); line too long (123 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21579 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe3d01fada31f1b48de6c1403e7d2955114d8078 Gerrit-Change-Number: 21579 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 11 Jul 2024 18:33:18 +0000 Gerrit-HasComments: Yes
