Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21557 )
Change subject: IMPALA-13088, IMPALA-13109: Use RoaringBitmap instead of sorted vector of int64s ...................................................................... Patch Set 10: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/21557/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21557/8//COMMIT_MSG@22 PS8, Line 22: lots of records > Added a section at the end. Thanks for adding these. Maybe for these details the Jira would be actually a better place? http://gerrit.cloudera.org:8080/#/c/21557/9/be/src/exec/iceberg-delete-builder.h File be/src/exec/iceberg-delete-builder.h: http://gerrit.cloudera.org:8080/#/c/21557/9/be/src/exec/iceberg-delete-builder.h@119 PS9, Line 119: RoaringBitmap64 > That's a great idea. Would you mind creating a Jira ticket for this? Created a ticket: IMPALA-13217 http://gerrit.cloudera.org:8080/#/c/21557/9/fe/src/main/java/org/apache/impala/planner/IcebergDeleteNode.java File fe/src/main/java/org/apache/impala/planner/IcebergDeleteNode.java: http://gerrit.cloudera.org:8080/#/c/21557/9/fe/src/main/java/org/apache/impala/planner/IcebergDeleteNode.java@201 PS9, Line 201: // Let's calculate with some overhead per roaring bitmap. > I updated the calculations to have 512 bytes overhead per roaring bitmap. A Thanks, I guess it's safe enough now! -- To view, visit http://gerrit.cloudera.org:8080/21557 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib769965d094149e99c43e0044914d9ecccc76107 Gerrit-Change-Number: 21557 Gerrit-PatchSet: 10 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 12 Jul 2024 10:40:28 +0000 Gerrit-HasComments: Yes
