Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21031 )
Change subject: IMPALA-12709: Add support for hierarchical metastore event processing ...................................................................... Patch Set 20: (3 comments) http://gerrit.cloudera.org:8080/#/c/21031/20//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21031/20//COMMIT_MSG@31 PS20, Line 31: Please describe the pseudo events in the commit message. http://gerrit.cloudera.org:8080/#/c/21031/20/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/21031/20/be/src/catalog/catalog-server.cc@235 PS20, Line 235: DEFINE_int32(db_event_executors, 5, Please mention these new flags in the commit message so we can find them in the JIRA comment after this patch is merged. http://gerrit.cloudera.org:8080/#/c/21031/20/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/21031/20/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@863 PS20, Line 863: // Enqueue a drop table event to old db event executor and a create table event to : // new db event executor > I am not completely convinced that this is a good idea. Processing the drop Can we add synchronization for the drop and create events? I.e. the create event can't be processed until the drop event is processed. Or maybe it's simpler to put all events of the new and old tables to the same queue so we can guarantee this. -- To view, visit http://gerrit.cloudera.org:8080/21031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76d8a739f9db6d40f01028bfd786a85d83f9e5d6 Gerrit-Change-Number: 21031 Gerrit-PatchSet: 20 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Mon, 15 Jul 2024 06:49:33 +0000 Gerrit-HasComments: Yes
