Xuebin Su has posted comments on this change. ( http://gerrit.cloudera.org:8080/21581 )
Change subject: IMPALA-13115: Add query id to message of UNREACHABLE_IMPALADS ...................................................................... Patch Set 3: (2 comments) > Patch Set 2: > > (2 comments) > > This is something we could be more consistent about. Thanks. Hi Michael! Thanks for reviewing! http://gerrit.cloudera.org:8080/#/c/21581/2/tests/custom_cluster/test_process_failures.py File tests/custom_cluster/test_process_failures.py: http://gerrit.cloudera.org:8080/#/c/21581/2/tests/custom_cluster/test_process_failures.py@156 PS2, Line 156: query_id = handle.get_handle().id > You can get this with Thank you! I didn't noticed this module before. I think it might be better to import the `ErrorCode` module than to make `generate_error_codes.py` import-able. So in the new patch set (patch set 3), I - refactored both `get_error_formatter()` and `test_kill_restart_worker()` to use the `ErrorCode` module, and - moved `get_error_formatter()` from `generate_error_codes.py` to be a static method of `ImpalaTestSuite`. Hope that can make the code cleaner. What do you think? Thanks! http://gerrit.cloudera.org:8080/#/c/21581/2/tests/custom_cluster/test_process_failures.py@157 PS2, Line 157: error_code = TErrorCode.UNREACHABLE_IMPALADS > A part of me prefers having the explicit string here, as it makes it easier Thank you! -- To view, visit http://gerrit.cloudera.org:8080/21581 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72260687ad395f97972e65ffcb47846e9de75bfb Gerrit-Change-Number: 21581 Gerrit-PatchSet: 3 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Mon, 15 Jul 2024 07:35:43 +0000 Gerrit-HasComments: Yes
