Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21143 )
Change subject: IMPALA-12856: Event processor should ignore processing partition with empty partition values ...................................................................... Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/21143/6/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/21143/6/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2926 PS6, Line 2926: * Reload the HdfsPartitions which correspond to the given partitions. > The problem of ignoring the partition is we might have stale table metadata When the partitions are empty we have no way of fetching the partition again from HMS since we don't/can't form a partition name from an empty partition. So I think ignoring the empty partition is the best way to proceed here. http://gerrit.cloudera.org:8080/#/c/21143/7/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/21143/7/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2614 PS7, Line 2614: > This should be removed otherwise the next check is useless. Ack http://gerrit.cloudera.org:8080/#/c/21143/7/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2925 PS7, Line 2925: > nit: "ignore the partition"? CommitTxnEvent could modify multiple partition This method is only used by MetastoreEvents#AlterPartitionEvent(). We don't have a way of fetching the partitions from HMS since partition values are empty. http://gerrit.cloudera.org:8080/#/c/21143/7/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2929 PS7, Line 2929: li > should be "{}" Ack http://gerrit.cloudera.org:8080/#/c/21143/7/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2930 PS7, Line 2930: Event Parti > nit: toString() can be removed since it's implicitly called. Ack -- To view, visit http://gerrit.cloudera.org:8080/21143 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2469930ccd74948325f1723bd8b2bd6aad02d09 Gerrit-Change-Number: 21143 Gerrit-PatchSet: 8 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 18 Jul 2024 05:13:30 +0000 Gerrit-HasComments: Yes
