Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21588 )
Change subject: IMPALA-13226: Rename TupleCacheInfo.finalize() to finalizeHash() ...................................................................... IMPALA-13226: Rename TupleCacheInfo.finalize() to finalizeHash() TupleCacheInfo.finalize() unintentionally overwrites Object.finalize() which is called by the JVM garbage collector when garbage collection determines that there are no more references to the object. Usually the finalize method is overrided to dispose of system resources or to perform other cleanup. TupleCacheInfo.finalize() is not meant to be used during GC. We'd better use another method name to avoid confusion. This patch renames it to finalizeHash(). Also fixed some stale comments. Change-Id: I657c4f14b074b7c16dc7d126b0c8b5083b8f19c6 Reviewed-on: http://gerrit.cloudera.org:8080/21588 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/planner/PlanFragment.java M fe/src/main/java/org/apache/impala/planner/PlanNode.java M fe/src/main/java/org/apache/impala/planner/TupleCacheInfo.java M fe/src/test/java/org/apache/impala/planner/TupleCacheInfoTest.java 4 files changed, 21 insertions(+), 24 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I657c4f14b074b7c16dc7d126b0c8b5083b8f19c6 Gerrit-Change-Number: 21588 Gerrit-PatchSet: 4 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]>
