Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21599 )
Change subject: IMPALA-13243: Update Dropwizard Metrics to 4.2.x ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21599/1/java/pom.xml File java/pom.xml: http://gerrit.cloudera.org:8080/#/c/21599/1/java/pom.xml@398 PS1, Line 398: <version>${dropwizard-metrics.version}</version> : </dependency> : <dependency> : <groupId>io.dropwizard.metrics</groupId> : <artifactId>metrics-jvm</artifactId> : <version>${dropwizard-metrics.version}</version> : </dependency> : <dependency> : <groupId>io.dropwizard.metrics</groupId> : <artifactId > Can we add a comment that this is only needed by HMS? In the future when Im Done. dependencyManagement entries don't hurt to leave around, as they only fix the version if the dependency is included by a statement elsewhere. But it's a useful comment anyway. -- To view, visit http://gerrit.cloudera.org:8080/21599 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie9bec7a7c23194604430531bd83b25c5969e888e Gerrit-Change-Number: 21599 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 22 Jul 2024 21:30:48 +0000 Gerrit-HasComments: Yes
