Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21611 )
Change subject: IMPALA-13230: Dump stacktrace for impala-shell when it receives SIGUSR1 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21611/1/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/21611/1/tests/shell/test_shell_interactive.py@362 PS1, Line 362: assert "Current thread" in result.stderr Did a test, the contents of result.stderr could be truncated when the assertion failed, I added result.stderr as the assertion message like below, and it print the full error message then. Would be better to add the assertion message. assert "Current thread" in result.stderr, result.stderr -- To view, visit http://gerrit.cloudera.org:8080/21611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7dae2686b65a1a4f02488abadca3b3c90e48bf1 Gerrit-Change-Number: 21611 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 25 Jul 2024 01:30:56 +0000 Gerrit-HasComments: Yes
