Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/20447 )
Change subject: IMPALA-13039: AES Encryption/ Decryption Support in Impala ...................................................................... Patch Set 13: (9 comments) > Uploaded patch set 13. http://gerrit.cloudera.org:8080/#/c/20447/12/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/20447/12/be/src/exprs/string-functions-ir.cc@1855 PS12, Line 1855: EncryptionKey encryption_key; > nit: this variable name could be more descriptive Done http://gerrit.cloudera.org:8080/#/c/20447/12/be/src/exprs/string-functions-ir.cc@1856 PS12, Line 1856: AES_CIPHER_MODE cipher_mode; > nit: I'm not sure why mode_ has an underscore at the end. That's usually re Done http://gerrit.cloudera.org:8080/#/c/20447/12/be/src/exprs/string-functions-ir.cc@1893 PS12, Line 1893: // Append spaces for gcm_tag in case of GCM mode > use t.IsGcmMode() Done http://gerrit.cloudera.org:8080/#/c/20447/12/be/src/exprs/string-functions-ir.cc@1910 PS12, Line 1910: // Append gcm_tag to encrypted buffer > use t.IsGcmMode() Done http://gerrit.cloudera.org:8080/#/c/20447/12/be/src/exprs/string-functions-ir.cc@1941 PS12, Line 1941: EncryptionKey encryption_key; > nit: this variable name could be more descriptive Done http://gerrit.cloudera.org:8080/#/c/20447/12/be/src/exprs/string-functions-ir.cc@1942 PS12, Line 1942: AES_CIPHER_MODE cipher_mode; > nit: I'm not sure why mode_ has an underscore at the end. That's usually re Done http://gerrit.cloudera.org:8080/#/c/20447/12/be/src/exprs/string-functions-ir.cc@1975 PS12, Line 1975: // Remove spaces and set value of gcm_tag in case of GCM mode > use t.IsGcmMode() Done http://gerrit.cloudera.org:8080/#/c/20447/10/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/20447/10/be/src/util/openssl-util.cc@245 PS10, Line 245: if (IsGcmMode()) { > Please add a comment about that. Done http://gerrit.cloudera.org:8080/#/c/20447/12/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/20447/12/be/src/util/openssl-util.cc@343 PS12, Line 343: void EncryptionKey::set_gcm_tag(uint8_t* expr, int len) { > nit: inconsistent spacing around '+' operator. Choose one (looks like we te Done -- To view, visit http://gerrit.cloudera.org:8080/20447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3902f2b1d95da4d06995cbd687e79c48e16190c9 Gerrit-Change-Number: 20447 Gerrit-PatchSet: 13 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Thu, 25 Jul 2024 15:25:22 +0000 Gerrit-HasComments: Yes
