Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/10358 )
Change subject: IMPALA-6802 (part 3): Clean up authorization tests ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10358/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java: http://gerrit.cloudera.org:8080/#/c/10358/1/fe/src/test/java/org/apache/impala/analysis/AuthorizationTestV2.java@750 PS1, Line 750: .error(selectError("functional.alltypes"), onColumn("functional", : "alltypes", "id", allExcept(TPrivilegeLevel.ALL, TPrivilegeLevel.SELECT))); I'm not sure this test makes sense because you can only grant SELECT at the column level. Maybe change the column name and remove "allExcept". I know this pattern is already used a lot of other places, but looking at the select tests, I don't think it's covered that the user is granted select to other (possibly all) columns except one, and that it should still fail. Maybe the existing tests can remain if case additional column privileges are added, but we still need to cover the other case. -- To view, visit http://gerrit.cloudera.org:8080/10358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9681cc3c7094db33ab7c5caa69b99dd803b908b7 Gerrit-Change-Number: 10358 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Adam Holley <g...@holleyism.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Comment-Date: Fri, 11 May 2018 15:02:28 +0000 Gerrit-HasComments: Yes
