Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21606 )
Change subject: IMPALA-13252: Consistently use PrintId to print TUniqueId ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/21606/7/tests/common/patterns.py File tests/common/patterns.py: http://gerrit.cloudera.org:8080/#/c/21606/7/tests/common/patterns.py@35 PS7, Line 35: 2**64 - 1 > Ideal way would be to precompute it. If I have some other reason to modify Yeah, precompute would be better. One more place you might want to check is whether this line needs to be changed, "https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/common/KuduTransactionManager.java#L65"; -- To view, visit http://gerrit.cloudera.org:8080/21606 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If01bf20a240debbbd4c0a22798045ea03f17b28e Gerrit-Change-Number: 21606 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 26 Jul 2024 20:49:48 +0000 Gerrit-HasComments: Yes
