Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21606 )
Change subject: IMPALA-13252: Consistently use PrintId to print TUniqueId ...................................................................... IMPALA-13252: Consistently use PrintId to print TUniqueId Some logging formats TUniqueId inconsistently by relying on the Thrift to_string/toString generated printers. This makes it difficult to track a specific query through logs. Adds operator<<(ostream, TUniqueId) to simplify logging TUniqueId correctly, uses PrintId instead of toString in Java, and adds a verifier to test_banned_log_messages to ensure TUniqueId is not printed in logs. Change-Id: If01bf20a240debbbd4c0a22798045ea03f17b28e Reviewed-on: http://gerrit.cloudera.org:8080/21606 Reviewed-by: Yida Wu <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/util/debug-util.h M fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java M fe/src/main/java/org/apache/impala/common/KuduTransactionManager.java M fe/src/main/java/org/apache/impala/service/Frontend.java M tests/common/patterns.py M tests/custom_cluster/test_custom_statestore.py M tests/verifiers/test_banned_log_messages.py 7 files changed, 35 insertions(+), 12 deletions(-) Approvals: Yida Wu: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/21606 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If01bf20a240debbbd4c0a22798045ea03f17b28e Gerrit-Change-Number: 21606 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]>
