Surya Hebbar has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/21593 )
Change subject: IMPALA-13233: Represent phases of each instance separately on the query timeline ...................................................................... IMPALA-13233: Represent phases of each instance separately on the query timeline Representing phases of multiple instances in a single bar with dividers makes it challenging to distinguish between the perimeters of each instance's phases, hindering other instances that have already started with the subsequent phase. Hence, the correlation between the recorded profile metrics and the user's desired representation is less. To improve this representation, the phases of each fragment's instances are now being shown parallelly on the query timeline, making it easier to understand the distribution of start time and end time of different instance's phases. When there are more than 4 instances for a phase, respective timestamps are bucketed into 4 groups. Each group's timestamps are averaged and then displayed on the timeline. A tooltip containing the following additional details is displayed, when hovering on a plane node's bucketed phase rectangle. - With respect to the hovered on bucketed phase rectangle - No. of instances - Event's Maximum Timestamp (in seconds) - Event's Minimum Timestamp (in seconds) Outlines are drawn at the top and bottom of each plan node, according to the timestamp of the instances' final closing phase. The attribute 'stroke-dasharray' has been used to add separators between the perimeters of each instance's phases, instead of an additional SVG line element each time. Redundant calls to 'appendChild' methods and setting fragment's ID after each iteration have been removed. Optional arguments have been removed from all 'getSVG*' functions. Replaced equality operators with strict equality operators. Manually tested with various profiles, sizes ranging from 4MB to 430MB. Change-Id: Ied8a5966e9e4111bf7aa25aee11d23881daad7d2 --- M www/queries.tmpl M www/query_backends.tmpl M www/query_detail_tabs.tmpl M www/query_finstances.tmpl M www/query_plan.tmpl M www/query_summary.tmpl M www/query_timeline.tmpl M www/rpcz.tmpl M www/scripts/query_timeline/chart_commons.js M www/scripts/query_timeline/fragment_diagram.js M www/scripts/query_timeline/fragment_metrics_diagram.js M www/scripts/query_timeline/global_dom.js M www/scripts/query_timeline/host_utilization_diagram.js 13 files changed, 222 insertions(+), 114 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/21593/2 -- To view, visit http://gerrit.cloudera.org:8080/21593 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ied8a5966e9e4111bf7aa25aee11d23881daad7d2 Gerrit-Change-Number: 21593 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]>
