Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/21619 )
Change subject: [tools] Update plan-graph.py ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Thanks for addressing my earlier comments Riza! I only have one last comment and do not have any other suggestion. http://gerrit.cloudera.org:8080/#/c/21619/5/bin/diagnostics/experimental/plan-graph.py File bin/diagnostics/experimental/plan-graph.py: http://gerrit.cloudera.org:8080/#/c/21619/5/bin/diagnostics/experimental/plan-graph.py@755 PS5, Line 755: which will highlight query operator that " : "returns more than 50 times of rows than the estimate. Is my understanding correct that in order to highlight this (number of returned rows followed by estimated number of rows enclosed in parentheses, e.g., 72 (1)), we also have to add the option '--estimate' at https://gerrit.cloudera.org/c/21619/5/bin/diagnostics/experimental/plan-graph.py#743 when running the script? In other words, is it true that this could not be highlighted if we do not add '--estimate'? If this is the case, then maybe it's good to point this out in the string of 'help'. -- To view, visit http://gerrit.cloudera.org:8080/21619 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I22b0188bba3eef120c3e4b0f48408088123c4650 Gerrit-Change-Number: 21619 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 01 Aug 2024 00:18:15 +0000 Gerrit-HasComments: Yes
