Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10370 )
Change subject: IMPALA-7010: don't run memory usage tests on non-HDFS ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10370/2/testdata/workloads/functional-query/queries/QueryTest/insert-mem-limit.test File testdata/workloads/functional-query/queries/QueryTest/insert-mem-limit.test: http://gerrit.cloudera.org:8080/#/c/10370/2/testdata/workloads/functional-query/queries/QueryTest/insert-mem-limit.test@3 PS2, Line 3: # Check that hdfs writers respects mem_limit. > maybe add comments to the test files saying the mem limit is tuned for 3 no Done http://gerrit.cloudera.org:8080/#/c/10370/2/tests/common/skip.py File tests/common/skip.py: http://gerrit.cloudera.org:8080/#/c/10370/2/tests/common/skip.py@130 PS2, Line 130: mem_usage_different = pytest.mark.skipif(IS_LOCAL, : reason="Memory limit too low when running single node") > do we still need that? should all of these tests be "tuned_for_minicluster" Done. The local filesystem tests run with a single impalad, so it ends up with 3x the memory consumption in some cases. -- To view, visit http://gerrit.cloudera.org:8080/10370 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9686195a29dde2d87b19ef8bb0e93e08f8bee662 Gerrit-Change-Number: 10370 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Fri, 11 May 2018 18:41:43 +0000 Gerrit-HasComments: Yes
