Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21617 )
Change subject: IMPALA-13256: Support more than 2G rows for COUNT(*) on jdbc table ...................................................................... IMPALA-13256: Support more than 2G rows for COUNT(*) on jdbc table Function DatabaseAccessor.getTotalNumberOfRecords() is defined with return data type as int. This caused Impala to throw an exception when executing COUNT(*) query for jdbc tables with more than 2G rows. This patch fixed the issue by changing the function return type as long. It also made number of rows in each TRowBatch fetched from jdbc data source not to exceed 2G. Testing: - Passed core-test and tpcds test for jdbc tables. - Manually created a jdbc table jdbc_table with more than 2G rows, verified that query 'select count(*) from jdbc_table' returned correct number of rows. Detailed steps were added in the comments of IMPALA-13256. Change-Id: I47db58300cbe3270bab07da02c3fcde6d7072334 Reviewed-on: http://gerrit.cloudera.org:8080/21617 Reviewed-by: Michael Smith <[email protected]> Reviewed-by: Abhishek Rawat <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exec/data-source-scan-node.cc M fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java M fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/DatabaseAccessor.java M fe/src/main/java/org/apache/impala/extdatasource/jdbc/dao/GenericJdbcDatabaseAccessor.java 4 files changed, 19 insertions(+), 11 deletions(-) Approvals: Michael Smith: Looks good to me, but someone else must approve Abhishek Rawat: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/21617 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I47db58300cbe3270bab07da02c3fcde6d7072334 Gerrit-Change-Number: 21617 Gerrit-PatchSet: 6 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]>
