Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21638 )

Change subject: IMPALA-13270: Fix IllegalStateException on runtime filter
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21638/2/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java
File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java:

http://gerrit.cloudera.org:8080/#/c/21638/2/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@1431
PS2, Line 1431: Preconditions.checkState(matched);
Please add error message. Maybe like this:

Preconditions.checkState(matched, "No SlotId found for RuntimeFilter %s SlotRef 
%s", filter, slotRef);



--
To view, visit http://gerrit.cloudera.org:8080/21638
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I23c7bcf33e5185f10a6ae475debb8ab70a2ec5eb
Gerrit-Change-Number: 21638
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Fri, 02 Aug 2024 19:56:41 +0000
Gerrit-HasComments: Yes

Reply via email to