Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21639 )
Change subject: IMPALA-13252: Always use PrintId for TUniqueId ...................................................................... IMPALA-13252: Always use PrintId for TUniqueId Thrift types provide their own overload of operator<<. In GCC, the overload added in debug-util.h is preferred, but in Clang the first overload (from Thrift generated code) is preferred. I don't see a good way to augment the Thrift definition to use PrintId, so this patch reverts the overload in debug-util.h and uses PrintId explicitly. Change-Id: Ic536c12ed67d9d473c7ac7f1e05ebc537ff485d4 Reviewed-on: http://gerrit.cloudera.org:8080/21639 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Yida Wu <[email protected]> Reviewed-by: Michael Smith <[email protected]> --- M be/src/runtime/coordinator.cc M be/src/util/debug-util.h 2 files changed, 1 insertion(+), 5 deletions(-) Approvals: Impala Public Jenkins: Verified Yida Wu: Looks good to me, but someone else must approve Michael Smith: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/21639 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic536c12ed67d9d473c7ac7f1e05ebc537ff485d4 Gerrit-Change-Number: 21639 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]>
