Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21644 )
Change subject: IMPALA-13276: Revise the documentation of 'RUNTIME_FILTER_WAIT_TIME_MS' ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21644/2/docs/topics/impala_runtime_filter_wait_time_ms.xml File docs/topics/impala_runtime_filter_wait_time_ms.xml: http://gerrit.cloudera.org:8080/#/c/21644/2/docs/topics/impala_runtime_filter_wait_time_ms.xml@43 PS2, Line 43: Note that the wait time for a runtime filter is with respect to the registration : time of the runtime filter instead of the time when a scan node calls : RuntimeFilter::WaitForArrival() to wait for a filter This sounds too detail for user that has not see the code. I'd like to offer this alternative: "Note that the wait time for a runtime filter is with respect to the beginning of Prepare phase instead of the the beginning of Open phase of a Scan node.". Prepare and Open is mentioned in query profile, like this: Fragment Instance Lifecycle Event Timeline Prepare Finished: 4ms (4462120) Open Finished: 49ms (49257941) First Batch Produced: 49ms (49289159) First Batch Sent: 49ms (49290220) ExecInternal Finished: 50ms (50073685) ... Node Lifecycle Event Timeline Open Started: 49ms (49173880) Open Finished: 49ms (49251183) First Batch Requested: 49ms (49258867) First Batch Returned: 49ms (49288201) Last Batch Returned: 49ms (49288380) Closed: 49ms (49295062) -- To view, visit http://gerrit.cloudera.org:8080/21644 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic98e23a902a65e4fa41a628d4a3edb1894660fb4 Gerrit-Change-Number: 21644 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 05 Aug 2024 23:18:06 +0000 Gerrit-HasComments: Yes
