Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21649 )
Change subject: IMPALA-13252: (Addendum) PrintId cancel query ...................................................................... Patch Set 1: Code-Review+2 nit: Using subprocess.run(), TestBannedLogMessages::assert_message_absent can be improved by also printing out the grep result if returncode == 1. -- To view, visit http://gerrit.cloudera.org:8080/21649 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id17af7bfd51264ce147878072b739845e3a6cfec Gerrit-Change-Number: 21649 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Tue, 06 Aug 2024 18:59:22 +0000 Gerrit-HasComments: No
