[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/18977 )
Change subject: IMPALA-10408: Support build using Apache components ...................................................................... Patch Set 17: (4 comments) Ok. I'll work on it soon. Thanks! http://gerrit.cloudera.org:8080/#/c/18977/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18977/15//COMMIT_MSG@8 PS15, Line 8: > Could you add some notes as the commit message? E.g. overview of this patch Thanks. I added an additional comment. http://gerrit.cloudera.org:8080/#/c/18977/15/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/18977/15/bin/impala-config.sh@249 PS15, Line 249: export APACHE_HADOOP_VERSION=3.3.6 > Redundant backslash "\" Thanks a lot! http://gerrit.cloudera.org:8080/#/c/18977/15/bin/impala-config.sh@358 PS15, Line 358: USE_APACHE > nit: Can we use a more concrete name, e.g. USE_APACHE_BUILDS, USE_APACHE_BI Thanks to letting me know. I'll change it with USE_APACHE_COMPONENTS. http://gerrit.cloudera.org:8080/#/c/18977/15/java/TableFlattener/pom.xml File java/TableFlattener/pom.xml: http://gerrit.cloudera.org:8080/#/c/18977/15/java/TableFlattener/pom.xml@67 PS15, Line 67: <dependency> : <groupId>commons-lang</groupId> : <artifactId>commons-lang</artifactId> : <version>${commons-io.version}</version> : </dependency> > Is this added for some reason? Could you mention the compilation error with Without this, I failed to build it. [INFO] --------------< org.apache.impala:nested-table-flattener >-------------- [INFO] Building Impala Nested Table Flattener 4.4.0-SNAPSHOT [15/17] [INFO] from TableFlattener/pom.xml [INFO] --------------------------------[ jar ]--------------------------------- [INFO] [INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ nested-table-flattener --- [INFO] [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ nested-table-flattener --- [INFO] Using 'UTF-8' encoding to copy filtered resources. [INFO] skip non existing resourceDirectory /eubnara-impala/java/TableFlattener/src/main/resources [INFO] [INFO] --- maven-compiler-plugin:3.11.0:compile (default-compile) @ nested-table-flattener --- [INFO] Changes detected - recompiling the module! :source [INFO] Compiling 5 source files with javac [debug target 1.8] to target/classes [INFO] /eubnara-impala/java/TableFlattener/src/main/java/org/apache/impala/infra/tableflattener/Main.java: /eubnara-impala/java/TableFlattener/src/main/java/org/apache/impala/infra/tableflattener/Main.java uses or overrides a deprecated API. [INFO] /eubnara-impala/java/TableFlattener/src/main/java/org/apache/impala/infra/tableflattener/Main.java: Recompile with -Xlint:deprecation for details. [INFO] ------------------------------------------------------------- [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /eubnara-impala/java/TableFlattener/src/main/java/org/apache/impala/infra/tableflattener/SchemaFlattener.java:[26,31] package org.apache.commons.lang does not exist [ERROR] /eubnara-impala/java/TableFlattener/src/main/java/org/apache/impala/infra/tableflattener/SchemaFlattener.java:[163,21] cannot find symbol symbol: class NotImplementedException location: class org.apache.impala.infra.tableflattener.SchemaFlattener [INFO] 2 errors [INFO] ------------------------------------------------------------- [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Apache Impala Parent POM 4.4.0-SNAPSHOT ............ SUCCESS [ 0.157 s] [INFO] Test Data Generator 4.4.0-SNAPSHOT ................. SUCCESS [ 1.191 s] [INFO] impala-minimal-s3a-aws-sdk 4.4.0-SNAPSHOT .......... SUCCESS [ 34.182 s] [INFO] impala-minimal-hive-exec 4.4.0-SNAPSHOT ............ SUCCESS [ 2.508 s] [INFO] Impala Executor Dependencies 4.4.0-SNAPSHOT ........ SUCCESS [ 0.323 s] [INFO] Apache Impala External Data Source 4.4.0-SNAPSHOT .. SUCCESS [ 0.003 s] [INFO] Apache Impala External Data Source API 4.4.0-SNAPSHOT SUCCESS [ 1.212 s] [INFO] Apache Impala External Data Source Sample 4.4.0-SNAPSHOT SUCCESS [ 0.056 s] [INFO] Apache Impala External Data Source Test Library 4.4.0-SNAPSHOT SUCCESS [ 0.064 s] [INFO] Apache Impala Query Event Hook API 4.4.0-SNAPSHOT .. SUCCESS [ 0.035 s] [INFO] YARN Extras 4.4.0-SNAPSHOT ......................... SUCCESS [ 0.212 s] [INFO] Apache Impala Query Engine Frontend 4.4.0-SNAPSHOT . SUCCESS [ 21.402 s] [INFO] Apache Impala External Data Source JDBC Library 4.4.0-SNAPSHOT SUCCESS [ 0.273 s] [INFO] external-frontend 1.0 .............................. SUCCESS [ 0.221 s] [INFO] Impala Nested Table Flattener 4.4.0-SNAPSHOT ....... FAILURE [ 0.103 s] [INFO] test-hive-udfs 1.0 ................................. SKIPPED [INFO] test-corrupt-hive-udfs 1.0 ......................... SKIPPED [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:02 min [INFO] Finished at: 2024-04-27T22:47:52Z [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project nested-table-flattener: Compilation failure: Compilation failure: [ERROR] /eubnara-impala/java/TableFlattener/src/main/java/org/apache/impala/infra/tableflattener/SchemaFlattener.java:[26,31] package org.apache.commons.lang does not exist [ERROR] /eubnara-impala/java/TableFlattener/src/main/java/org/apache/impala/infra/tableflattener/SchemaFlattener.java:[163,21] cannot find symbol [ERROR] symbol: class NotImplementedException [ERROR] location: class org.apache.impala.infra.tableflattener.SchemaFlattener [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn <args> -rf :nested-table-flattener -- To view, visit http://gerrit.cloudera.org:8080/18977 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8730dd182b367c9daa94303937ad249db72b1399 Gerrit-Change-Number: 18977 Gerrit-PatchSet: 17 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 07 Aug 2024 11:39:36 +0000 Gerrit-HasComments: Yes
