Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/21644 )
Change subject: IMPALA-13276: Revise the documentation of 'RUNTIME_FILTER_WAIT_TIME_MS' ...................................................................... Patch Set 5: > Patch Set 4: > > Thanks, it looks good to me now. > I have noticed another place that describes this query option: > https://impala.apache.org/docs/build/html/topics/impala_runtime_filtering.html > > "By default, each scan node waits for up to 1 second (1000 milliseconds) for > filters to arrive" > I think that it is misleading at the moment - maybe something short like "The > time is counted from the start of executing the query - see the query > option's doc page for details" Thanks Csaba! I have revised the patch set 4 accordingly. Let me know if there is any other suggestion. -- To view, visit http://gerrit.cloudera.org:8080/21644 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic98e23a902a65e4fa41a628d4a3edb1894660fb4 Gerrit-Change-Number: 21644 Gerrit-PatchSet: 5 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 07 Aug 2024 17:45:41 +0000 Gerrit-HasComments: No
