Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19205 )
Change subject: IMPALA-13294: Add support for long polling to avoid client side wait ...................................................................... Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/19205/9/be/src/service/client-request-state.h File be/src/service/client-request-state.h: http://gerrit.cloudera.org:8080/#/c/19205/9/be/src/service/client-request-state.h@579 PS9, Line 579: std::mutex exec_state_lock_; > Can you add this lock to the list in https://github.com/apache/impala/blob/ The thread modifying the exec state always holds lock_ when acquiring this, so I added it to the list right above that point. I also updated the comment here. http://gerrit.cloudera.org:8080/#/c/19205/9/tests/hs2/test_hs2.py File tests/hs2/test_hs2.py: http://gerrit.cloudera.org:8080/#/c/19205/9/tests/hs2/test_hs2.py@391 PS9, Line 391: assert end_time - start_time < 1 > Can you also check that it is > 80ms to verify the assumption in line 80ms? Done http://gerrit.cloudera.org:8080/#/c/19205/9/tests/hs2/test_hs2.py@417 PS9, Line 417: 075 > here + line 456: do you think that this will be stable enough? I am a bit w That's a good point. I changed this to 100ms. If we run into problems on ASAN, we can bump the value or use a higher value for slow builds. http://gerrit.cloudera.org:8080/#/c/19205/9/tests/hs2/test_hs2.py@455 PS9, Line 455: # statement, so it should hit the error within 200 milliseconds. : assert end_time - start_time < 0.2 Ran into a test failure locally, so I bumped this to 400 milliseconds. -- To view, visit http://gerrit.cloudera.org:8080/19205 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I72ca595c5dd8a33b936f078f7f7faa5b3f0f337d Gerrit-Change-Number: 19205 Gerrit-PatchSet: 9 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 12 Aug 2024 21:21:56 +0000 Gerrit-HasComments: Yes
