ttttttz has posted comments on this change. ( http://gerrit.cloudera.org:8080/19937 )
Change subject: IMPALA-12164: Avoid referencing non-materialized slots in analytic limit pushdown ...................................................................... Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/19937/18/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/19937/18/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@1905 PS18, Line 1905: if (foundConstantFalse) break; > Was the intention here really to skip registerConjunct/markConstantConjunct Hi, Michael Smith! Thank you for your comment. Our current logic stops processing further conjuncts once a constant FALSE is found, aiming to improve efficiency since the overall condition is already determined to be FALSE at that point. I understand your concern that this behavior differs from the registerOnClauseConjuncts method, which may continue processing all conjuncts regardless. However, I am not sure if this causes any issues. Is it unsafe even if we mark it as assigned? -- To view, visit http://gerrit.cloudera.org:8080/19937 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e078f48863c38062e1e624a1ff3e9317092466f Gerrit-Change-Number: 19937 Gerrit-PatchSet: 18 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Thu, 15 Aug 2024 02:31:09 +0000 Gerrit-HasComments: Yes
