Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21597 )
Change subject: IMPALA-13246: Smallify strings during broadcast exchange ...................................................................... Patch Set 7: Code-Review+2 (2 comments) Carrying +2 from Zoltan http://gerrit.cloudera.org:8080/#/c/21597/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21597/4//COMMIT_MSG@17 PS4, Line 17: Measured 0.5-1% improvement in TPCH(4 > Thanks for taking a look. Maybe for very wide tables with lots of string va Did two more measurements, the improvements were 0.82% and 0.91%. Rewritten >1% to 0.5-1% http://gerrit.cloudera.org:8080/#/c/21597/6/be/src/runtime/smallable-string.h File be/src/runtime/smallable-string.h: http://gerrit.cloudera.org:8080/#/c/21597/6/be/src/runtime/smallable-string.h@145 PS6, Line 145: VarLenIfSmall > nit: I find the name a bit confusing, maybe 'VarLen()', 'HeapLen()', 'Requi Went with VarLenIfSmallified(), I agree that it is clearer. -- To view, visit http://gerrit.cloudera.org:8080/21597 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I281d77c7a241ebfe8716eb5c975f0660601aec1b Gerrit-Change-Number: 21597 Gerrit-PatchSet: 7 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 15 Aug 2024 06:07:22 +0000 Gerrit-HasComments: Yes
