Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21657 )
Change subject: IMPALA-13284: Loading test data on Apache Hive3 ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/21657/3/testdata/bin/generate-schema-statements.py File testdata/bin/generate-schema-statements.py: http://gerrit.cloudera.org:8080/#/c/21657/3/testdata/bin/generate-schema-statements.py@271 PS3, Line 271: " TBLPROPERTIES('write.format.default'='{}')" I think it'd be better to check there is no TBLPROPERTIES clause in the statement, as raising an error here would be clearer than getting an error from Hive when we execute the transformed statement. -- To view, visit http://gerrit.cloudera.org:8080/21657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f52c91602da8822b0f46f19dc4111c7187ce400 Gerrit-Change-Number: 21657 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 16 Aug 2024 09:00:53 +0000 Gerrit-HasComments: Yes
