Hello Quanlong Huang, Riza Suminto, Zoltan Borok-Nagy, Csaba Ringhofer, Impala
Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21679
to look at the new patch set (#2).
Change subject: IMPALA-13302: Analyze new rewrite exprs
......................................................................
IMPALA-13302: Analyze new rewrite exprs
Ensures all new expressions created during ExprRewriteRule evaluation
are analyzed so later rules will evaluate them. Centralize analyzing and
logging new expressions created by rewrite rules. Fixes reAnalyze
marking conjunct assignment before new conjuncts are registered.
Adds ExprRewriteRules tests that previously hit the new Precondition in
markConjunctAssigned, and rewrite PlannerTest.
Updates tests:
- one IMPALA-8030 test is fixed because it now applies
ExtractCommonConjunctRule after NormalizeBinaryPredicatesRule.
- several TPCDS tests have slight changes in how constant arithmetic
expression results are stored; FoldConstantsRule retains the original
type of the ArithmeticExpr, which may have a larger type (such as
SMALLINT instead of TINYINT) than the resulting NumericLiteral needs.
Change-Id: I6be731c2ea79c96e51d199c822e2cb34e5bb3028
---
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/rewrite/BetweenToCompoundRule.java
M fe/src/main/java/org/apache/impala/rewrite/CountDistinctToNdvRule.java
M fe/src/main/java/org/apache/impala/rewrite/DefaultNdvScaleRule.java
M fe/src/main/java/org/apache/impala/rewrite/ExprRewriter.java
M fe/src/main/java/org/apache/impala/rewrite/ExtractCommonConjunctRule.java
M fe/src/main/java/org/apache/impala/rewrite/NormalizeExprsRule.java
M fe/src/main/java/org/apache/impala/rewrite/SimplifyCastStringToTimestamp.java
M fe/src/test/java/org/apache/impala/analysis/ExprRewriteRulesTest.java
M fe/src/test/java/org/apache/impala/planner/PlannerTest.java
M testdata/workloads/functional-planner/queries/PlannerTest/card-scan.test
A testdata/workloads/functional-planner/queries/PlannerTest/rewrite.test
M testdata/workloads/functional-planner/queries/PlannerTest/tpcds/tpcds-q28.test
M testdata/workloads/functional-planner/queries/PlannerTest/tpcds/tpcds-q37.test
M testdata/workloads/functional-planner/queries/PlannerTest/tpcds/tpcds-q64.test
M testdata/workloads/functional-planner/queries/PlannerTest/tpcds/tpcds-q82.test
M
testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/tpcds-q28.test
M
testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/tpcds-q37.test
M
testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/tpcds-q64.test
M
testdata/workloads/functional-planner/queries/PlannerTest/tpcds_cpu_cost/tpcds-q82.test
20 files changed, 263 insertions(+), 147 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/21679/2
--
To view, visit http://gerrit.cloudera.org:8080/21679
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6be731c2ea79c96e51d199c822e2cb34e5bb3028
Gerrit-Change-Number: 21679
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
