Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/20447 )
Change subject: IMPALA-13039: AES Encryption/ Decryption Support in Impala ...................................................................... Patch Set 16: (10 comments) > Uploaded patch set 16. http://gerrit.cloudera.org:8080/#/c/20447/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20447/15//COMMIT_MSG@31 PS15, Line 31: Multiple AES modes: GCM, CFB, CTR for encryption, and GCM, CFB, CTR > nit: I'd add a space after ':' Done http://gerrit.cloudera.org:8080/#/c/20447/13/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/20447/13/be/src/exprs/string-functions-ir.cc@1877 PS13, Line 1877: > nit: prefer using Substitute for concatenation, so Done http://gerrit.cloudera.org:8080/#/c/20447/15/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/20447/15/be/src/exprs/string-functions-ir.cc@2102 PS15, Line 2102: ctx->SetError( Substitute("IV vector required for $0 mode", > nit: use Substitute here as well. Done http://gerrit.cloudera.org:8080/#/c/20447/15/be/src/exprs/string-functions.h File be/src/exprs/string-functions.h: http://gerrit.cloudera.org:8080/#/c/20447/15/be/src/exprs/string-functions.h@138 PS15, Line 138: /// AES encryption functions in Impala, using OpenSSL libraries > nit: Impala and OpenSSL are proper nouns, should use correct capitalization Done http://gerrit.cloudera.org:8080/#/c/20447/15/be/src/util/openssl-util.h File be/src/util/openssl-util.h: http://gerrit.cloudera.org:8080/#/c/20447/15/be/src/util/openssl-util.h@137 PS15, Line 137: /// (2) The plaintext and the Additional Authenticated Data (AAD) are the two > nit: space between "Data" and "(AAD)". Done http://gerrit.cloudera.org:8080/#/c/20447/15/be/src/util/openssl-util.h@181 PS15, Line 181: return mode_ == AES_CIPHER_MODE::AES_256_GCM > Line 181 should be intended 2 from the function definition, and the followi Done http://gerrit.cloudera.org:8080/#/c/20447/15/be/src/util/openssl-util.h@187 PS15, Line 187: return mode_ == AES_CIPHER_MODE::AES_256_ECB > ditto Done http://gerrit.cloudera.org:8080/#/c/20447/13/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/20447/13/be/src/util/openssl-util.cc@382 PS13, Line 382: if (IsModeSupported(AES_CIPHER_MODE::AES_256_GCM)) { : return AES_CIPH > There's no difference in how they're handled here, so you could use fallthr Done http://gerrit.cloudera.org:8080/#/c/20447/13/be/src/util/openssl-util.cc@407 PS13, Line 407: } else if (strncmp("AES_256_CTR", str, len) == 0) > I don't see it changed. It throws this error, so didn't change it: error: enumeration value ‘INVALID’ not handled in switch http://gerrit.cloudera.org:8080/#/c/20447/15/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/20447/15/be/src/util/openssl-util.cc@227 PS15, Line 227: // of the supported cipher block modes. Moreover, numerous modes (e.g., CTR) are > line too long (109 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/20447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3902f2b1d95da4d06995cbd687e79c48e16190c9 Gerrit-Change-Number: 20447 Gerrit-PatchSet: 16 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Mon, 19 Aug 2024 18:15:37 +0000 Gerrit-HasComments: Yes
