Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21671 )
Change subject: IMPALA-13274: Filter out illegal output for certain join nodes ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/21671/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21671/8//COMMIT_MSG@17 PS8, Line 17: - Add e2e test Please elaborate the significance of rand() or abs(1) existence in both subquery and main query. Is it true that these function can trigger the bug because FoldConstantsRule does not apply to them? http://gerrit.cloudera.org:8080/#/c/21671/8/testdata/workloads/functional-query/queries/QueryTest/miss-tuple-joins.test File testdata/workloads/functional-query/queries/QueryTest/miss-tuple-joins.test: http://gerrit.cloudera.org:8080/#/c/21671/8/testdata/workloads/functional-query/queries/QueryTest/miss-tuple-joins.test@15 PS8, Line 15: INSERT INTO test_miss_tuple_1 VALUES (1); : ==== : ---- QUERY : INSERT INTO test_miss_tuple_1 VALUES (2); : ==== : ---- QUERY : INSERT INTO test_miss_tuple_1 VALUES (3); Can be simplified into one: INSERT INTO test_miss_tuple_1 VALUES (1), (2), (3); -- To view, visit http://gerrit.cloudera.org:8080/21671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50b82d85737025df2fdd9e7ab0fca2385e642415 Gerrit-Change-Number: 21671 Gerrit-PatchSet: 8 Gerrit-Owner: ttttttz <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Reviewer: ttttttz <[email protected]> Gerrit-Comment-Date: Mon, 19 Aug 2024 20:36:14 +0000 Gerrit-HasComments: Yes
