Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21608 )
Change subject: IMPALA-13254: Optimize REFRESH for Iceberg tables ...................................................................... Patch Set 15: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21608/15/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/21608/15/be/src/common/global-flags.cc@421 PS15, Line 421: "file listing to load file metadata. If number of new files are less or equal to this, " line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21608/15/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/21608/15/fe/src/main/java/org/apache/impala/catalog/IcebergFileMetadataLoader.java@131 PS15, Line 131: List<Pair<FileSystem, ContentFile<?>>> filesSupportsStorageIds = Lists.newLinkedList(); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c99a28eb16275efdff52e0ea2711c0c6036719 Gerrit-Change-Number: 21608 Gerrit-PatchSet: 15 Gerrit-Owner: Fu Lili <[email protected]> Gerrit-Reviewer: Fu Lili <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 20 Aug 2024 07:02:37 +0000 Gerrit-HasComments: Yes
