Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21143 )
Change subject: IMPALA-12856: Event processor should ignore processing partition with empty partition values ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/21143/10/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/21143/10/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2667 PS10, Line 2667: LOG.error("Unmatched numbers of partition values: expected={}, actual={} for " + > nit: can we add an error log as L2673 does before returning null? Ack http://gerrit.cloudera.org:8080/#/c/21143/10/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2987 PS10, Line 2987: // only reload partitions that have more recent write id : if (hdfsPartition != null > nit: the original indention looks better. At least they shouldn't use the s Ack -- To view, visit http://gerrit.cloudera.org:8080/21143 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2469930ccd74948325f1723bd8b2bd6aad02d09 Gerrit-Change-Number: 21143 Gerrit-PatchSet: 11 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 21 Aug 2024 21:56:37 +0000 Gerrit-HasComments: Yes
