Fang-Yu Rao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21688 )
Change subject: IMPALA-13262: Do not always migrate inferred predicates into inline view ...................................................................... IMPALA-13262: Do not always migrate inferred predicates into inline view This patch removes a predicate inferred from a set of analytic predicates if both sides of the inferred predicate reference the same TupleId when migrating those analytic predicates into an inline view. This is to prevent Impala from pushing the inferred conjunct to the scan node before the analytic functions are applied, which could produce an incorrect result. Testing: - Added additional query and planner test cases to verify Impala's behavior after this patch. - Verified the patch passed the core tests. Change-Id: I6e2632b3b1a140ae0104ceba4e2f474ac1bbcda1 Reviewed-on: http://gerrit.cloudera.org:8080/21688 Reviewed-by: Michael Smith <[email protected]> Reviewed-by: Riza Suminto <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java M testdata/workloads/functional-planner/queries/PlannerTest/inline-view.test M testdata/workloads/functional-query/queries/QueryTest/inline-view.test 3 files changed, 211 insertions(+), 10 deletions(-) Approvals: Michael Smith: Looks good to me, but someone else must approve Riza Suminto: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/21688 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6e2632b3b1a140ae0104ceba4e2f474ac1bbcda1 Gerrit-Change-Number: 21688 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
